feat(firestore): global option to turn on implicit orderby#2337
Merged
Conversation
product-auto-label
bot
added
size: m
wu-hui
force-pushed
the
feat-implicit-orderby
branch
from
a855d28 to
84bc5f2
Compare
MarkDuckworth
approved these changes
Mar 11, 2026
Contributor
MarkDuckworth
left a comment
MarkDuckworth
left a comment
There was a problem hiding this comment.
LGTM. The JavaDoc comment on the setting could use a little cleanup for readabiliy, but looks good
google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreOptions.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreOptions.java
Outdated
Show resolved
Hide resolved
wu-hui
force-pushed
the
feat-implicit-orderby
branch
from
84bc5f2 to
488db23
Compare
Contributor
Author
|
Improved the JavaDoc readability for in as requested. |
Contributor
Author
|
Improved the JavaDoc readability for |
wu-hui
force-pushed
the
feat-implicit-orderby
branch
from
488db23 to
27db8ca
Compare
wu-hui
force-pushed
the
feat-implicit-orderby
branch
from
dbdc2ac to
979aead
Compare
product-auto-label
bot
added
size: l
MarkDuckworth
approved these changes
Mar 17, 2026
wu-hui
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new global option
alwaysUseImplicitOrderByinFirestoreOptionsto control whether implicit order bys (e.g. for inequality queries) are sent to the backend. By default, it isfalse(meaning the SDK only sends explicit order bys). Enterprise users can opt-in to always send them by setting this new option totrueto mimic Standard tier behavior.Related modifications:
alwaysUseImplicitOrderBytoFirestoreOptions.Query.javahandles this serialization flag to send implicit orders for fields with inequalities.Watch.javawas updated to always send implicit orders for streaming, regardless of the flag.